fix: force non-legacy import attributes babel output #386
+364
−818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
approved these changes
Nov 24, 2024
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 27, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 28, 2024
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.3.3 | 4.3.4 | ## [v4.3.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#434-2024-11-26) ##### Add Vite 6 to peerDependencies range Vite 6 is highly backward compatible, not much to add! ##### Force Babel to output spec compliant import attributes [#386](vitejs/vite-plugin-react#386) The default was an old spec (`with type: "json"`). We now enforce spec compliant (`with { type: "json" }`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So, what's happened is that
@babel/plugin-syntax-import-attributeswas necessary until quite recently, but it's now included in babel core since 7.26 https://babeljs.io/blog/2024/10/25/7.26.0#import-attributes-16579. Previously users would've seen more direct error message instead:This monorepo had 7.25, so I actually got this error. For now, I updated
@babel/coreto make it work. I'll review pending renovate PR #373 since that includes@babel/coreupdate too.For user with version < 7.26, I assume
generatorOpts.importAttributesKeywordwould be no-op, so probably it's fine to always add it on our side.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).